feat(website): add download dialog to search page #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaoran-chen
force-pushed
the
757-download-panel
branch
from
aa72ae1
to
47a22a9
Compare
chaoran-chen
force-pushed
the
757-download-panel
branch
from
47a22a9
to
e247f2f
Compare
|
Really nice – Q: should you have to agree to the terms if you haven't chosen to include restricted sequences? (I haven't had a chance to look at the code yet, so haven't reviewed for now) |
|
At the moment, yes. Happy to change it to only showing up when restricted data are chosen if you think that's better. |
website/src/components/SearchPage/DownloadDialog/DownloadActiveFilters.tsx
Outdated
Show resolved
Hide resolved
website/src/components/SearchPage/DownloadDialog/DownloadDialog.tsx
Outdated
Show resolved
Hide resolved
website/src/components/SearchPage/DownloadDialog/OptionBlock.tsx
Outdated
Show resolved
Hide resolved
website/src/components/SearchPage/DownloadDialog/OptionBlock.tsx
Outdated
Show resolved
Hide resolved
website/src/components/SearchPage/DownloadDialog/OptionBlock.tsx
Outdated
Show resolved
Hide resolved
website/src/components/SearchPage/DownloadDialog/OptionBlock.tsx
Outdated
Show resolved
Hide resolved
website/src/components/SearchPage/DownloadDialog/generateDownloadUrl.ts
Outdated
Show resolved
Hide resolved
chaoran-chen
force-pushed
the
757-download-panel
branch
2 times, most recently
from
be6f702
to
47a76b1
Compare
fengelniederhammer
approved these changes
Jan 30, 2024
website/src/components/SearchPage/DownloadDialog/OptionBlock.tsx
Outdated
Show resolved
Hide resolved
chaoran-chen
force-pushed
the
757-download-panel
branch
from
47a76b1
to
8b42025
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #757
Preview: https://757-download-panel.preview.k3s.loculus.org/
Screenshots
Future work
PR Checklist
[ ] All necessary documentation has been adapted.